Skip to content

Posix compliance fixes. (Fixes BUGZ-4040)

nordugrid-arc-bot requested to merge (removed):checkbashism_fixes into next

Begin arcbot message
This merge request is automatically copied from !1301 (merged) orginally made by @maikenp
End arcbot message

First installation of ARC on Debian11 I encountered problems with the submission scripts preventing jobs to be submitted. The job..errors file showed

----- starting submit_slurm_job -----
/usr/share/arc/submit-SLURM-job: 145: [: unexpected operator
SLURM jobname: hello_test
/usr/share/arc/submit-SLURM-job: 709: [: HEPSPEC 14.998: unexpected operator
/usr/share/arc/submit-SLURM-job: 712: Bad substitution

These three lines refer to

(submit-SLURM-job: 145) https://source.coderefinery.org/nordugrid/arc/-/blob/master/src/services/a-rex/lrms/lrms_common.sh.in#L145 (submit-SLURM-job: 709) https://source.coderefinery.org/nordugrid/arc/-/blob/master/src/services/a-rex/lrms/submit_common.sh#L703 (submit-SLURM-job: 712) https://source.coderefinery.org/nordugrid/arc/-/blob/master/src/services/a-rex/lrms/submit_common.sh#L706

In addition

  • Replaced source with . in submit_common
  • Replaced ´[[´ test in scan-SLURM-job.in for the special treatment of cancelled jobs

The first was causing issues related to the RTE's where the parameters were not being set.

Edited by Maiken

Merge request reports