Remove broken, but dead, code. Part 8 of (BUGZ-4206)

The error in question was a constructor that captured a reference to one of its arguments, creating a dangling pointer.

The code in question looks like it might be an unfinished change: The local vomses_match class does not conform to the interface of its base class (which requires a const method), and the instance of that local class that is constructed on the stack is never used. The parameter that causes this warning could probably be passed by reference to the constructor but it's unclear whether the method could be made const, given the side effect to members. The most sensible thing to here appears to be to remove the code altogether. If this is an in-progress fix then the code could/should be moved to a branch or to a ticket until it can be completed.