Skip to content

Adding job exists check for the other methods that require jobid input from user

Maiken requested to merge maikenp/arc:arcctl_protect_wrong_jobid into next

Avoid ugly TypeError if wrong job-id string is entered by the user. For instance in the case where 1 char is wrong (11 instead of 12 chars in this case)

[root@uio-atlas-ce1 control]# arcctl job attr 326c45616ef
Traceback (most recent call last):
  File "/sbin/arcctl", line 88, in <module>
    ctl_class(ControlCommon.get_parsed_arcconf(cmd_args.config)).control(cmd_args)
  File "/usr/lib64/python3.9/site-packages/arc/control/Jobs.py", line 456, in control
    self.job_getattr(args)
  File "/usr/lib64/python3.9/site-packages/arc/control/Jobs.py", line 357, in job_getattr
    job_attrs = self.__parse_job_attrs(args.jobid)
  File "/usr/lib64/python3.9/site-packages/arc/control/Jobs.py", line 124, in __parse_job_attrs
    if os.path.exists(attr_file):
  File "/usr/lib64/python3.9/genericpath.py", line 19, in exists
    os.stat(path)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

Merge request reports