Skip to content

Remove usage of PWD in scan-condor-job

Maiken requested to merge maikenp/arc:condor_controldir_path into next

The original code in ARC 6 used $PWD to grab path of controldir - example

https://source.coderefinery.org/nordugrid/arc/-/blob/master/src/services/a-rex/lrms/condor/scan-condor-job.in?ref_type=heads#L147

gramifile="job.$gridid.grami"

    [ -f "$gramifile" ] || { log "grami file not found: $PWD/$gramifile"; return 1; }

However, this is no longer true for ARC 7 - and the gramifile variable already contains the full path to the file (in the same way as all the other file paths for locals errors etc)

https://source.coderefinery.org/nordugrid/arc/-/blob/next/src/services/a-rex/lrms/condor/scan-condor-job.in?ref_type=heads#L201

gramifile="${basenames[$localid]}/grami"

So keeping $PWD in all the similar file paths (local errors etc) for ARC 7 not correct.

Edited by Maiken

Merge request reports

Loading